Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add json schema for the updated Adobe I/O Developer Console configuration file format, fixed tests #194

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 22, 2020

Description

The Adobe I/O Developer Console configuration file format has changed for the config that is to be imported via app create --import or app init --import.

Validation is done via a json schema definition now (format: json-schema draft v7) and not in the code. Tests have been updated and coverage is 100%.

How Has This Been Tested?

npm test
# init
aio app:init Foo1 --import my.valid.config.json
# select defaults in Yeoman
cd Foo1
aio config --local
aio config --env

# create
aio app:create Foo2 --import my.valid.config.json
cd Foo2
aio config --local
aio config --env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          621       624    +3     
  Branches        80        79    -1     
=========================================
+ Hits           621       624    +3     
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)
src/lib/import.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f286dc...0f50ed1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant